fix: occasional "socket hang up" errors in APM server intake requests #179
Conversation
Use the 'agentkeepalive' alternative to Node.js core `http.Agent` for keep-alive handling to get the `freeSocketTimeout` option that can timeout kept-alive (aka "free") sockets before getting in the range of the downstream APM Server (or Lambda extension) HTTP Keep-Alive timeout. This avoids occasional ECONNRESET errors. Fixes: #2594
github-actions
bot
added
the
agent-nodejs
…req socket. It doesn't hurt to reset it for later node versions
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Swapping in a new http.Agent seems like a pretty big change, but if we are going to do it agentkeepalive looks like a reasonable choice. It's a long standing project with a maintainer that's still semi-engaged. And if it fixes some lambda problems then I guess we're in "trust our tests and yolo be agile" territory.
The specific code changes themselves appear to do what they intend to.
I see that we're ensuring keepAliveMsecs, maxSockets, maxFreeSockets, and freeSocketTimeout are set on our configuration object.
I see we're conditionally choosing which keep alive constructor-function/class to use (the HTTP or HTTPS version) based on the protocol portion of the server URL.
I see we're then instantiating an object with that constructor function/class and including two new configuration fields -- freeSocketTimeout and serverTimeout.
Approving.
| const end = Date.now() | ||
| const delta = end - start | ||
| t.ok(delta > 1000 && delta < 2000, 'timeout should occur between 1-2 seconds') | ||
| t.ok(delta > 1000 && delta < 2000, `timeout should occur between 1-2 seconds: delta=${delta}ms`) |
There was a problem hiding this comment.
+1 for some better test logging.
2 participants
Use the 'agentkeepalive' alternative to Node.js core
http.Agentfor keep-alive handling to get the
freeSocketTimeoutoption thatcan timeout kept-alive (aka "free") sockets before getting in the
range of the downstream APM Server (or Lambda extension) HTTP
Keep-Alive timeout. This avoids occasional ECONNRESET errors.
Refs: elastic/apm-agent-nodejs#2594
Checklist