Skip to content

Conversation

estolfo
Copy link
Contributor

@estolfo estolfo commented Jan 12, 2022

Resolve #75

@estolfo estolfo requested a review from astorm January 12, 2022 14:18
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jan 12, 2022
@ghost
Copy link

ghost commented Jan 12, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-13T10:13:51.671+0000

  • Duration: 7 min 54 sec

  • Commit: 4954fe6

Test stats 🧪

Test Results
Failed 0
Passed 78
Skipped 0
Total 78

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@astorm astorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 does the thing it says it does and fulfills the request in #75

I'd say the only thing left is getting our new env variable added to the docs at https://github.com/elastic/apm-aws-lambda/blob/main/docs/aws-lambda-extension.asciidoc#lambda_env and we can call this one good and merge it.

@estolfo
Copy link
Contributor Author

estolfo commented Jan 13, 2022

thanks for the reminder about the docs!

@estolfo
Copy link
Contributor Author

estolfo commented Jan 13, 2022

@astorm Updated the PR with documentation for the new env variable 👍🏼

@estolfo estolfo merged commit 36b882d into main Jan 17, 2022
@estolfo estolfo deleted the estolfo/background-send branch January 17, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce an optional background dispatching strategy

2 participants