Skip to content

Conversation

astorm
Copy link
Contributor

@astorm astorm commented Dec 7, 2021

Adds a profiler runner that's capable of testing multiple scenarios.

Next steps:

  • Auto deploy the latest version of our extension layer
  • Document runner

Future, Post this PR steps:

  • Auto download any needed tools (lpt-0.1.jar) and auto configure
  • Post results to some elastic search instance
  • Auto run npm install (or other installs?) for code in profile/code?
  • Run regularly somehow

@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Dec 7, 2021
@ghost
Copy link

ghost commented Dec 7, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-07T03:16:09.822+0000

  • Duration: 8 min 3 sec

  • Commit: 9f3a8ce

Test stats 🧪

Test Results
Failed 0
Passed 78
Skipped 0
Total 78

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@estolfo
Copy link
Contributor

estolfo commented Dec 9, 2021

Thanks for starting this @astorm. I watched the screencast and looked at the code. I'm not an expert at nodejs so can't comment on the code itself, unfortunately. The only comment I have is, is there a way to make this more general so we could use it for testing? It's essentially doing the same thing I was trying to do with the sam cli: defining different lambda functions and configurations and running the lambda function. The only difference is, the sam cli allows you to run the function locally.
I don't want to broaden the scope for this task too much, so maybe that's not worth it.

@astorm astorm marked this pull request as ready for review December 23, 2021 00:10
@astorm astorm merged commit a4461fb into main Dec 23, 2021
@astorm astorm deleted the astorm/cli-profile branch December 23, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants