Skip to content

feat: adds a development doc with the steps for a release #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2021
Merged

feat: adds a development doc with the steps for a release #89

merged 2 commits into from
Dec 21, 2021

Conversation

astorm
Copy link
Contributor

@astorm astorm commented Dec 3, 2021

Adds a DEVELOPMENT.md to the repo that includes information on how we're building a release.

@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Dec 3, 2021
@ghost
Copy link

ghost commented Dec 3, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-03T01:19:57.869+0000

  • Duration: 7 min 34 sec

  • Commit: 1ede3de

Test stats 🧪

Test Results
Failed 0
Passed 78
Skipped 0
Total 78

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@astorm astorm marked this pull request as ready for review December 3, 2021 01:31
@astorm astorm requested a review from estolfo December 3, 2021 01:31
estolfo
estolfo reviewed Dec 7, 2021
View reviewed changes
apm-lambda-extension/DEVELOPMENT.md Outdated

4. Entering a release title, description, and binaries

5. Clicking on No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cliffhanger!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, forgot that last git push. corrected.

estolfo
estolfo reviewed Dec 7, 2021
View reviewed changes
Copy link
Contributor

@estolfo estolfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for documenting this! Just one comment on the cliffhanger at the end 😄

@astorm astorm merged commit dd49555 into main Dec 21, 2021
@astorm astorm deleted the astorm/how-to-release branch December 21, 2021 16:21
@ghost
Copy link

ghost commented Dec 21, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-21T16:18:26.414+0000

  • Duration: 7 min 32 sec

  • Commit: d6292bd

Test stats 🧪

Test Results
Failed 0
Passed 78
Skipped 0
Total 78

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estolfo estolfo estolfo left review comments

Assignees

No one assigned

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@astorm @estolfo