Skip to content

feat: make GOARCH configurable in Makefile and auto-detect in installer #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2021
Merged

feat: make GOARCH configurable in Makefile and auto-detect in installer #68

merged 2 commits into from
Oct 27, 2021

Conversation

astorm
Copy link
Contributor

@astorm astorm commented Oct 27, 2021 •
edited
Loading

This PR

  • Alters the Makefile to allow users to specify a GOARCH value -- defaults to amd64
  • Alters the Makefile so that build-and-publish will also produce an amd64.zip or arm64.zip
  • Alters the CLI installer to auto-detect a function's architecture
  • Removes old GoExampleExtensionLayer commands from Makefile

@astorm astorm marked this pull request as draft October 27, 2021 04:10
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Oct 27, 2021
@astorm astorm requested a review from estolfo October 27, 2021 04:16
@astorm astorm marked this pull request as ready for review October 27, 2021 04:16
@ghost
Copy link

ghost commented Oct 27, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-27T04:10:34.472+0000

  • Duration: 7 min 47 sec

  • Commit: 00374ed

Test stats 🧪

Test Results
Failed 0
Passed 66
Skipped 0
Total 66

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

estolfo
estolfo approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@estolfo estolfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@astorm astorm merged commit 9cd614c into main Oct 27, 2021
@astorm astorm deleted the astorm/build-arch branch November 15, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estolfo estolfo estolfo approved these changes

Assignees

No one assigned

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@astorm @estolfo