Skip to content

test: use 127.0.0.1 explicitly instead of resolving localhost #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2023
Merged

test: use 127.0.0.1 explicitly instead of resolving localhost #363

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb764ff
test: use 127.0.0.1 explicitly instead of resolving localhost
kruskall Jan 17, 2023
b205316
test: use 127.0.0.1 explicitly instead of resolving localhost
kruskall Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 19 additions & 28 deletions apmproxy/receiver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import (
"bytes"
"encoding/pem"
"io"
"net"
"net/http"
"net/http/httptest"
"strings"
Expand Down Expand Up @@ -56,7 +55,8 @@ func TestInfoProxy(t *testing.T) {
apmproxy.WithURL(apmServer.URL),
apmproxy.WithSecretToken("foo"),
apmproxy.WithAPIKey("bar"),
apmproxy.WithReceiverAddress(":1234"),
// Use ipv4 to avoid issues in CI
apmproxy.WithReceiverAddress("127.0.0.1:1234"),
apmproxy.WithReceiverTimeout(15*time.Second),
apmproxy.WithLogger(zaptest.NewLogger(t).Sugar()),
)
Expand All @@ -67,8 +67,7 @@ func TestInfoProxy(t *testing.T) {
require.NoError(t, apmClient.Shutdown())
}()

hosts, _ := net.LookupHost("localhost")
url := "http://" + hosts[0] + ":1234"
url := "http://127.0.0.1:1234"

// Create a request to send to the extension
req, err := http.NewRequest(http.MethodGet, url, nil)
Expand Down Expand Up @@ -101,7 +100,7 @@ func TestInfoProxyErrorStatusCode(t *testing.T) {
apmproxy.WithURL(apmServer.URL),
apmproxy.WithSecretToken("foo"),
apmproxy.WithAPIKey("bar"),
apmproxy.WithReceiverAddress(":1234"),
apmproxy.WithReceiverAddress("127.0.0.1:1234"),
apmproxy.WithReceiverTimeout(15*time.Second),
apmproxy.WithLogger(zaptest.NewLogger(t).Sugar()),
)
Expand All @@ -112,8 +111,7 @@ func TestInfoProxyErrorStatusCode(t *testing.T) {
require.NoError(t, apmClient.Shutdown())
}()

hosts, _ := net.LookupHost("localhost")
url := "http://" + hosts[0] + ":1234"
url := "http://127.0.0.1:1234"

// Create a request to send to the extension
req, err := http.NewRequest(http.MethodGet, url, nil)
Expand All @@ -137,7 +135,7 @@ func TestInfoProxyUnreachable(t *testing.T) {
apmproxy.WithURL(apmServer.URL),
apmproxy.WithSecretToken("foo"),
apmproxy.WithAPIKey("bar"),
apmproxy.WithReceiverAddress(":1234"),
apmproxy.WithReceiverAddress("127.0.0.1:1234"),
apmproxy.WithReceiverTimeout(15*time.Second),
apmproxy.WithLogger(zaptest.NewLogger(t).Sugar()),
)
Expand All @@ -148,8 +146,7 @@ func TestInfoProxyUnreachable(t *testing.T) {
require.NoError(t, apmClient.Shutdown())
}()

hosts, _ := net.LookupHost("localhost")
url := "http://" + hosts[0] + ":1234"
url := "http://127.0.0.1:1234"

// Create a request to send to the extension
req, err := http.NewRequest(http.MethodGet, url, nil)
Expand Down Expand Up @@ -177,7 +174,7 @@ func Test_handleInfoRequest(t *testing.T) {
apmproxy.WithURL("https://example.com"),
apmproxy.WithSecretToken("foo"),
apmproxy.WithAPIKey("bar"),
apmproxy.WithReceiverAddress(":1234"),
apmproxy.WithReceiverAddress("127.0.0.1:1234"),
apmproxy.WithReceiverTimeout(15*time.Second),
apmproxy.WithLogger(zaptest.NewLogger(t).Sugar()),
)
Expand All @@ -190,8 +187,7 @@ func Test_handleInfoRequest(t *testing.T) {
}()

// Create a request to send to the extension
hosts, _ := net.LookupHost("localhost")
url := "http://" + hosts[0] + ":1234/intake/v2/events"
url := "http://127.0.0.1:1234/intake/v2/events"
req, err := http.NewRequest(http.MethodPost, url, strings.NewReader(agentRequestBody))
require.NoError(t, err)
// Add headers to the request
Expand All @@ -217,7 +213,7 @@ func Test_handleIntakeV2EventsQueryParam(t *testing.T) {
// Create extension config and start the server
apmClient, err := apmproxy.NewClient(
apmproxy.WithURL(apmServer.URL),
apmproxy.WithReceiverAddress(":1234"),
apmproxy.WithReceiverAddress("127.0.0.1:1234"),
apmproxy.WithReceiverTimeout(15*time.Second),
apmproxy.WithLogger(zaptest.NewLogger(t).Sugar()),
)
Expand All @@ -227,8 +223,7 @@ func Test_handleIntakeV2EventsQueryParam(t *testing.T) {
require.NoError(t, apmClient.Shutdown())
}()

hosts, _ := net.LookupHost("localhost")
url := "http://" + hosts[0] + ":1234/intake/v2/events?flushed=true"
url := "http://127.0.0.1:1234/intake/v2/events?flushed=true"

// Create a request to send to the extension
req, err := http.NewRequest(http.MethodPost, url, bytes.NewReader(body))
Expand Down Expand Up @@ -259,7 +254,7 @@ func Test_handleIntakeV2EventsNoQueryParam(t *testing.T) {
// Create extension config and start the server
apmClient, err := apmproxy.NewClient(
apmproxy.WithURL(apmServer.URL),
apmproxy.WithReceiverAddress(":1234"),
apmproxy.WithReceiverAddress("127.0.0.1:1234"),
apmproxy.WithReceiverTimeout(15*time.Second),
apmproxy.WithLogger(zaptest.NewLogger(t).Sugar()),
)
Expand All @@ -269,8 +264,7 @@ func Test_handleIntakeV2EventsNoQueryParam(t *testing.T) {
require.NoError(t, apmClient.Shutdown())
}()

hosts, _ := net.LookupHost("localhost")
url := "http://" + hosts[0] + ":1234/intake/v2/events"
url := "http://127.0.0.1:1234/intake/v2/events"

// Create a request to send to the extension
req, err := http.NewRequest(http.MethodPost, url, bytes.NewReader(body))
Expand Down Expand Up @@ -302,7 +296,7 @@ func Test_handleIntakeV2EventsQueryParamEmptyData(t *testing.T) {
// Create extension config and start the server
apmClient, err := apmproxy.NewClient(
apmproxy.WithURL(apmServer.URL),
apmproxy.WithReceiverAddress(":1234"),
apmproxy.WithReceiverAddress("127.0.0.1:1234"),
apmproxy.WithReceiverTimeout(15*time.Second),
apmproxy.WithLogger(zaptest.NewLogger(t).Sugar()),
)
Expand All @@ -312,8 +306,7 @@ func Test_handleIntakeV2EventsQueryParamEmptyData(t *testing.T) {
require.NoError(t, apmClient.Shutdown())
}()

hosts, _ := net.LookupHost("localhost")
url := "http://" + hosts[0] + ":1234/intake/v2/events?flushed=true"
url := "http://127.0.0.1:1234/intake/v2/events?flushed=true"

// Create a request to send to the extension
req, err := http.NewRequest(http.MethodPost, url, bytes.NewReader(body))
Expand Down Expand Up @@ -351,7 +344,7 @@ func TestWithVerifyCerts(t *testing.T) {
apmproxy.WithURL(apmServer.URL),
apmproxy.WithSecretToken("foo"),
apmproxy.WithAPIKey("bar"),
apmproxy.WithReceiverAddress(":1234"),
apmproxy.WithReceiverAddress("127.0.0.1:1234"),
apmproxy.WithReceiverTimeout(15*time.Second),
apmproxy.WithLogger(zaptest.NewLogger(t).Sugar()),
apmproxy.WithVerifyCerts(false),
Expand All @@ -363,8 +356,7 @@ func TestWithVerifyCerts(t *testing.T) {
require.NoError(t, apmClient.Shutdown())
}()

hosts, _ := net.LookupHost("localhost")
url := "http://" + hosts[0] + ":1234"
url := "http://127.0.0.1:1234"

// Create a request to send to the extension
req, err := http.NewRequest(http.MethodGet, url, nil)
Expand Down Expand Up @@ -402,7 +394,7 @@ func TestWithRootCerts(t *testing.T) {
apmproxy.WithURL(apmServer.URL),
apmproxy.WithSecretToken("foo"),
apmproxy.WithAPIKey("bar"),
apmproxy.WithReceiverAddress(":1234"),
apmproxy.WithReceiverAddress("127.0.0.1:1234"),
apmproxy.WithReceiverTimeout(15*time.Second),
apmproxy.WithLogger(zaptest.NewLogger(t).Sugar()),
apmproxy.WithRootCerts(string(pemCert)),
Expand All @@ -414,8 +406,7 @@ func TestWithRootCerts(t *testing.T) {
require.NoError(t, apmClient.Shutdown())
}()

hosts, _ := net.LookupHost("localhost")
url := "http://" + hosts[0] + ":1234"
url := "http://127.0.0.1:1234"

// Create a request to send to the extension
req, err := http.NewRequest(http.MethodGet, url, nil)
Expand Down