Skip to content

build: Tag CSP resources according to policy #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2023
Merged

build: Tag CSP resources according to policy #355

merged 4 commits into from
Jan 10, 2023

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Jan 1, 2023 •
edited
Loading

Reuse apm-server tags module to share labels for the apm-server team. Tag resource accordingly.

Related to elastic/apm-server#9699

@kruskall
build: Tag CSP resources according to policy
cef77b5 
Reuse apm-server tags module to share labels for the apm-server team.
Tag resource accordingly.
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jan 1, 2023
@ghost
Copy link

ghost commented Jan 1, 2023 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-10T03:24:34.980+0000

  • Duration: 8 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 204
Skipped 2
Total 206

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

marclop
marclop reviewed Jan 3, 2023
View reviewed changes
@kruskall kruskall requested a review from marclop January 8, 2023 01:26
@kruskall
Copy link
Member Author

@marclop Thanks for the help and discussion with this!

I've pushed some changes

marclop
marclop approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kruskall kruskall enabled auto-merge (squash) January 10, 2023 02:43
@kruskall kruskall merged commit 5cf6e87 into elastic:main Jan 10, 2023
@kruskall kruskall deleted the build/cloud-resource-tags branch January 10, 2023 03:32
kruskall added a commit that referenced this pull request Jan 10, 2023
@kruskall
Revert "build: Tag CSP resources according to policy (#355)"
ac5233c 
This reverts commit 5cf6e87.
xenia-lang pushed a commit to xenia-lang/apm-aws-lambda that referenced this pull request Jan 13, 2023
@kruskall
build: Tag CSP resources according to policy (elastic#355)
3dbc62d 
* build: Tag CSP resources according to policy

Reuse apm-server tags module to share labels for the apm-server team.
Tag resource accordingly.

* testing: use aws provider default_tags in benchmarking tf script

* testing: remove tags support from tf-modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marclop marclop marclop approved these changes

Assignees

No one assigned

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kruskall @marclop