Create proxy transasction if not reported by agent

[lahsivjar]

Motivation

Create proxy transactions if agent is not able to report the transaction due to unexpected errors like OutOfMemory.

Related issues

Part of #315

Testing

(Currently, the PoC for agents is implemented only in golang so the lambda function must use go1.x runtime)

1. Create a lambda function (in golang) that causes an timeout (or OOM) and run it a few times.
2. Make sure to import apm-agent-go with go-agent PoC pull. Example function for reference.
3. Observe in elastic to assert that a transaction for the function invocation is reported as event.outcome: failure.

The above steps can also be executed using the testing/benchmarking module by editing the test function (same as this example).

[axw]

If we need to pass some kind of callback in, maybe make it an interface (or interfaces)? That would remove the direct dependency on accumulator.

I wonder if we should just move ProcessLogs out of this package though, and into package app.

[lahsivjar]

If we need to pass some kind of callback in, maybe make it an interface (or interfaces)? That would remove the direct dependency on accumulator.

Thanks for the tip, I have added an interface to remove accumulator dependency on logsapi.

I wonder if we should just move ProcessLogs out of this package though, and into package app.

This sounds worth trying. I can give it a try with the PR to remove the buffer from logsapi or do you think we should address it in this PR itself?

[axw]

Doing it in a separate PR sounds good.

[ghost]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-11-01T12:41:06.320+0000

• Duration: 9 min 57 sec

Test stats 🧪

Test	Results
Failed	0
Passed	202
Skipped	2
Total	204

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[axw]

This looks good to me now.

The approach you've taken of sending a partial transaction is quite similar to what @felixbarny suggested with the transaction-start event, and looks good. I still think it could be useful to send the whole payload to the extension and have it parse it, but that's a lot more work and can be deferred until/unless we need it. Maybe specifying a Content-Type would help us handle that change gracefully.

[axw]

LGTM, just one other minor comment.

[carsonip]

Tested extension on main branch (commit 3032883), with ESS 8.6.0 and a PoC that takes a param to decide whether it times out. Not all timed out calls are recorded in ES. Will have to investigate.

[carsonip]

Tested extension on main branch with ESS 8.6.0 and PoC with go agent on branch https://github.com/lahsivjar/apm-agent-go/tree/1323-lambdatxn

This PR is working well. Timed out requests will report event.outcome: failure, with the exception that if the first invocation fails in a new execution environment, the data will be dropped due to missing metadata. The discovery is shared with @lahsivjar @felixbarny @axw