-
Notifications
You must be signed in to change notification settings - Fork 35
ci: add smoke tests integration #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, but would you mind splitting this PR in two, so the .ci/jobs/**
are in a different PR, so we can easily merge and test whether the pipeline in this particular PR works as expected?
.ci/jobs
are quite static, so jobs are not generated in the CI as long as they are not merged, while .ci/*.groovy
are more dynamic as long as the Jenkins Multibranch Job has been created.
Co-authored-by: Victor Martinez <[email protected]>
Co-authored-by: Victor Martinez <[email protected]>
Sorry about the delay, there were a few issues with the current script (e.g. #319). I'll pick this up again today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's wait for #329 so we can test this PR without merging it
I've just added the support to run always when pushing into the main branch by default. And also support for running on PR basis by using the Jenkins UI. For instance, this particular PR can be validated manually by running the job -> https://apm-ci.elastic.co/job/library/job/apm-aws-lambda-smoketests-mbp/view/change-requests/job/PR-310/ |
@v1v Thank you for that! It seems the job is failing because the aws provider is not configured (missing credentials), could you help with that ? I'm not familiar with the process/guidelines regarding adding credentials to jenkins. |
Everything is in Vault, as far as I know it uses the secrets defined in What's the error? Maybe there are some missing permissions for the existing AWS account? |
|
I'm not much familiar with that error, I just searched and found:
In here I also see some references about some specific terraform configuration:
I'm not much familiar with the existing terraform/aws configuration for this project, that particular |
Initial work to integrate smoke testing scripts into CI.
Mostly inspired by the work in the mutating webhook and APM server, add make tasks to make testing easier and provide a target for CI to discover, run and cleanup the environment.
The tasks are flexible and support muiltiple smoke tests (currently there's only one).
Related to #217