Skip to content

Conversation

@estolfo
Copy link
Contributor

@estolfo estolfo commented Sep 27, 2021

We are currently continuing the function even if there's an error posting to the APM server. These changes return an error from the function if there's an error sending to the APM server.

Resolves #27

@estolfo estolfo requested a review from astorm September 27, 2021 13:08
@ghost
Copy link

ghost commented Sep 27, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-27T13:08:39.953+0000

  • Duration: 7 min 37 sec

  • Commit: 35ad0e3

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@astorm astorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 explicitly handling the error is worth getting into the extension and this does that, approving.

@estolfo estolfo marked this pull request as ready for review September 28, 2021 10:43
@estolfo estolfo merged commit 6523c06 into main Sep 28, 2021
@estolfo estolfo deleted the estolfo/handle-apm-server-err branch November 15, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension Error Causes {"message":"Internal Server Error"}?

3 participants