Skip to content

Added performance impact section to the docs #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 23, 2022
Merged

Added performance impact section to the docs #279

merged 7 commits into from
Aug 23, 2022

Conversation

AlexanderWert
Copy link
Member

No description provided.

@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Aug 18, 2022
felixbarny
felixbarny approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link

ghost commented Aug 18, 2022 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-22T11:41:03.311+0000

  • Duration: 7 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 130
Skipped 32
Total 162

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

trentm
trentm reviewed Aug 19, 2022
View reviewed changes
bmorelli25
bmorelli25 reviewed Aug 19, 2022
View reviewed changes
@AlexanderWert
Copy link
Member Author

@bmorelli25 Anything in addition needed for the backporting of this change? Or are we ready to merge?

@bmorelli25
Copy link
Member

Nope. AFAIK, auto backporting isn't enabled for this repo, so it has to be done manually. I'll take care of it.

@bmorelli25 bmorelli25 merged commit f34edd3 into elastic:main Aug 23, 2022
@bmorelli25 bmorelli25 mentioned this pull request Aug 23, 2022
Merged
@bmorelli25
Copy link
Member

💔 Some backports could not be created

Status Branch Result
❌ 8.4 Code: 1; Args: ["push","bmorelli25","backport/8.4/pr-279:backport/8.4/pr-279","--force"]; To https://github.com/bmorelli25/apm-aws-lambda.git
! [remote rejected] backport/8.4/pr-279 -> backport/8.4/pr-279 (refusing to allow a Personal Access Token to create or update workflow .github/workflows/addToDocsProject.yml without workflow scope)
error: failed to push some refs to 'https://x-access-token:@github.com/bmorelli25/apm-aws-lambda.git'
✅ 8.3

Manual backport

To create the backport manually run:

backport --pr 279

Questions ?

Please refer to the Backport tool documentation

bmorelli25 added a commit to bmorelli25/apm-aws-lambda that referenced this pull request Aug 23, 2022
@AlexanderWert @bmorelli25 @trentm
Added performance impact section to the docs (elastic#279)
c8a0415 
* Added performance impact section to the docs

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Trent Mick <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Trent Mick <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Trent Mick <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update package size numbers in doc

Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
(cherry picked from commit f34edd3)
@bmorelli25 bmorelli25 mentioned this pull request Aug 23, 2022
Merged
@bmorelli25
Copy link
Member

💚 All backports created successfully

Status Branch Result
✅ 8.4

Questions ?

Please refer to the Backport tool documentation

bmorelli25 added a commit to bmorelli25/apm-aws-lambda that referenced this pull request Aug 23, 2022
@AlexanderWert @bmorelli25 @trentm
Added performance impact section to the docs (elastic#279)
e524d42 
* Added performance impact section to the docs

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Trent Mick <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Trent Mick <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Trent Mick <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update package size numbers in doc

Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
(cherry picked from commit f34edd3)
bmorelli25 added a commit that referenced this pull request Aug 23, 2022
@bmorelli25 @AlexanderWert
Added performance impact section to the docs (#279) (#286)
93aa7da 
* Added performance impact section to the docs

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Trent Mick <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Trent Mick <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Trent Mick <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update package size numbers in doc

Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
(cherry picked from commit f34edd3)

Co-authored-by: Alexander Wert <[email protected]>
bmorelli25 added a commit that referenced this pull request Aug 23, 2022
@bmorelli25 @AlexanderWert
Added performance impact section to the docs (#279) (#287)
bec1200 
* Added performance impact section to the docs

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Trent Mick <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Trent Mick <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Trent Mick <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update package size numbers in doc

Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
(cherry picked from commit f34edd3)

Co-authored-by: Alexander Wert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixbarny felixbarny felixbarny approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@estolfo estolfo Awaiting requested review from estolfo

+2 more reviewers

@trentm trentm trentm left review comments

@akhileshpok akhileshpok akhileshpok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AlexanderWert @bmorelli25 @trentm @felixbarny @akhileshpok