Skip to content

Conversation

axw
Copy link
Member

@axw axw commented Aug 12, 2022

Use Make targets, so CI behaves more like developer environments. This ensures license headers are checked in PRs.

Also, tidy up the Makefile a little:

  • zip now depends on build. This ensures a make zip in isolation won't zip a stale build and confuse unsuspecting people like me.
  • replace gen-notice with a non-PHONY NOTICE.txt target, by depending on go.mod

axw added 2 commits August 12, 2022 16:05
- zip depends on build
- replace gen-notice with NOTICE.txt, make it non-PHONY
  by depending on go.mod
Use Make targets, so CI behaves more like
developer environments. This ensures license
headers are checked in PRs.
@axw axw requested a review from kruskall August 12, 2022 08:08
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Aug 12, 2022
@ghost
Copy link

ghost commented Aug 12, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-12T08:08:59.997+0000

  • Duration: 8 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 130
Skipped 32
Total 162

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@kruskall kruskall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@axw axw merged commit 52b0f1e into elastic:main Aug 14, 2022
@axw axw deleted the ci-make-build branch August 14, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants