test: reenable main tests #275
Conversation
main_test was disabled after the global state for the logsapi listener was removed. The new approach is to choose a random port and pass the address to the app. Add a timeout to make sure tests don't hang.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
/test |
| // we cannot return a port that is already in use or it | ||
| // would return an error when creating the server. | ||
| // The solution is to spawn a test server to get a random | ||
| // port and immediately close it so that we can use the port. |
There was a problem hiding this comment.
This is racy though, as another process could also be trying to acquire an ephemeral port. If the test ends up being flaky, we may need to have the extension listen on an ephemeral port, log it, and then extract the listening port from the logs. Or something like that.
There was a problem hiding this comment.
Agree, the window to hit the race is small enough that I think it's safe to ignore. Another solution I had in mind was to use unix sockets.
2 participants
main_test was disabled after the global state for the logsapi
listener was removed.
The new approach is to choose a random port and pass the address
to the app.
Add a timeout to make sure tests don't hang.
Blocked by #249
Closes #249