fix: do not enqueue broken metrics data to the apm server

[kruskall]

If an error is returned when processing platform metrics, the
processed metrics are enqueued to the apm server regardless.

We can't assume anything about the processed metrics so we
return an error which is logged correctly.

[ghost]

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-07-28T16:00:13.182+0000

• Duration: 63 min 38 sec

Test stats 🧪

Test	Results
Failed	0
Passed	98
Skipped	32
Total	130

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[axw]

If an error is returned when processing platform metrics, the processed metrics are enqueued to the apm server regardless.

I don't think that's the case. We were logging the error, and only calling EnqueueAPMData in the non-error case. We would previously continue processing log events in the case where ProcessPlatformReport returned an error.

[kruskall]

If an error is returned when processing platform metrics, the processed metrics are enqueued to the apm server regardless.

I don't think that's the case. We were logging the error, and only calling EnqueueAPMData in the non-error case. We would previously continue processing log events in the case where ProcessPlatformReport returned an error.

uh!? I'm really sorry about this, the correct PR is #257. I'll close this one and add a reminder to myself to get enough sleep 😅

[axw]

No worries :)