Skip to content

Conversation

kruskall
Copy link
Member

This is the last step to eliminate global state. Moreover,
'apmproxy' and 'extension' are now completely separate and
do not depend on each other.

@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jul 28, 2022
@ghost
Copy link

ghost commented Jul 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-08T09:54:55.518+0000

  • Duration: 7 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 116
Skipped 32
Total 148

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kruskall kruskall force-pushed the feat/logger-package branch from c1a6b77 to 077cc0c Compare August 1, 2022 04:10
This is the last step to eliminate global state. Moreover,
'apmproxy' and 'extension' are now completely separate and
do not depend on each other.
@kruskall kruskall force-pushed the feat/logger-package branch from 077cc0c to 86ec377 Compare August 4, 2022 19:07
@kruskall kruskall marked this pull request as ready for review August 4, 2022 19:38
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

LGTM, but maybe we can cut down some of the repetition by using zaptest for constructing a logger. In the tests we can just panic/fail the test if the logger construction fails for some unexpected reason.

@kruskall kruskall merged commit 5fbe333 into elastic:main Aug 8, 2022
@kruskall kruskall deleted the feat/logger-package branch August 8, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants