Skip to content

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Jul 26, 2022

Start working on decoupling apm and extension package.
Shutdown the apm receiver gracefully and move away from
deprecated ioutil calls.

Still untested but ready for review

@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jul 26, 2022
@ghost
Copy link

ghost commented Jul 26, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-28T11:58:55.976+0000

  • Duration: 8 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 196
Skipped 64
Total 260

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Start working on decoupling apm and extension package.
Shutdown the apm receiver gracefully and move away from
deprecated ioutil calls.
@kruskall kruskall force-pushed the abstract/apm-client branch from 55a55ea to e59074f Compare July 27, 2022 20:07
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, loving this refactoring.

Just one minor thing: "apm" feels too generic of a package name. Perhaps call it "apmproxy", or something along those lines?

@kruskall
Copy link
Member Author

/test

@kruskall kruskall merged commit c3d7919 into elastic:main Jul 28, 2022
@kruskall kruskall deleted the abstract/apm-client branch July 28, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants