Skip to content

Conversation

kruskall
Copy link
Member

Create an app struct to hold the state of the application and
use functional options for flexibility.
Remove global extension client and avoid mixing test code
with app logic.

This is part of a bigger effort to improve testing and
decouple different components.

Create an app struct to hold the state of the application and
use functional options for flexibility.
Remove global extension client and avoid mixing test code
with app logic.

This is part of a bigger effort to improve testing and
decouple different components.
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jul 18, 2022
@ghost
Copy link

ghost commented Jul 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-20T09:37:50.912+0000

  • Duration: 33 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 224
Skipped 4
Total 228

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kruskall kruskall merged commit d478d5f into elastic:main Jul 20, 2022
@kruskall kruskall deleted the refactor/move-main-loop branch July 20, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants