Skip to content

refactor: replace signal handling with NotifyContext #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022
Merged

refactor: replace signal handling with NotifyContext #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions apm-lambda-extension/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,9 @@ var (
func main() {

// Global context
ctx, cancel := context.WithCancel(context.Background())
ctx, cancel := signal.NotifyContext(context.Background(), syscall.SIGTERM, syscall.SIGINT)
defer cancel()

sigs := make(chan os.Signal, 1)
signal.Notify(sigs, syscall.SIGTERM, syscall.SIGINT)
go func() {
s := <-sigs
cancel()
extension.Log.Infof("Received %v\n, exiting", s)
}()

cfg, err := config.LoadDefaultConfig(ctx)
if err != nil {
extension.Log.Fatalf("failed to load default config: %v", err)
Expand Down Expand Up @@ -102,6 +94,7 @@ func main() {
for {
select {
case <-ctx.Done():
extension.Log.Info("Received a signal, exiting...")
return
default:
var backgroundDataSendWg sync.WaitGroup
Expand Down