Generate NOTICE.txt
from deps in shipped binary
#215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation, using
go list -m -json all
, lists dependencies that aren't actually being used in the shipped binary.The change here lists only dependencies being shipped to the customer, then uses that information to query the full module information used by
go-license-detector
.Since this is a small project I manually verified that the dependencies don't themselves have any dependencies that should be included in our
NOTICE.txt
.Output of
go list
query:This can be verified against the binary:
https://go.dev/ref/mod#go-version-m