Skip to content

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Jun 3, 2022

Updating the Makefile to also add the license headers to the test examples written in python, java and js.

@simitt simitt requested a review from AlexanderWert June 3, 2022 12:47
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jun 3, 2022
go install github.com/elastic/[email protected]
go run github.com/elastic/[email protected] .
go run github.com/elastic/[email protected] -ext .java .
go run github.com/elastic/[email protected] -ext .js .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you wrote in the description:

js: adding the license header cannot be automated as the formatting would be changed, but the check can be automated and is done

Isn't this line adding / updating the license headers for .js files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed that line now. It changes the formatting/intentation on the .js files. I actually updated the headers for js files manually and then run the control script via the make check-licenses.

@ghost
Copy link

ghost commented Jun 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-03T13:00:38.968+0000

  • Duration: 7 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 196
Skipped 4
Total 200

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@AlexanderWert AlexanderWert self-requested a review June 3, 2022 12:59
@simitt simitt merged commit 11fdbbe into elastic:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants