Skip to content

Conversation

AlexanderWert
Copy link
Member

Closes #195

@AlexanderWert AlexanderWert requested a review from v1v May 30, 2022 14:20
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label May 30, 2022
@ghost
Copy link

ghost commented May 30, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-01T06:54:22.945+0000

  • Duration: 6 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 200
Skipped 4
Total 204

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments, only one question regarding the docker image for multiarch, as far as I see, the docker image will be different for x86 and arm. Is that the intended? I'm happy about this anyway, but wanted to double check if for any reasons we wanted a docker image multi-arch based instead, since it will require some other implementation


echo "INFO: Pushing image $DOCKER_PUSH_IMAGE to $DOCKER_REGISTRY_URL"

if [ ${WORKERS+x} ] # We are on a CI worker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not much familiar with WORKERS but CI is the default env variable if it helps

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this logic from the Java agent's push_docker.sh

@AlexanderWert
Copy link
Member Author

I see, the docker image will be different for x86 and arm. Is that the intended?

Yes it is intended. Depending on the AWS Lambda architecture the users would use the corresponding image to get the extension with the correct arch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish extension as a docker image

2 participants