-
Notifications
You must be signed in to change notification settings - Fork 35
Added building and pushing docker image for the lambda-extension #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d577d25
to
c8d1c60
Compare
c8d1c60
to
eed66b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments, only one question regarding the docker image for multiarch, as far as I see, the docker image will be different for x86 and arm. Is that the intended? I'm happy about this anyway, but wanted to double check if for any reasons we wanted a docker image multi-arch based instead, since it will require some other implementation
|
||
echo "INFO: Pushing image $DOCKER_PUSH_IMAGE to $DOCKER_REGISTRY_URL" | ||
|
||
if [ ${WORKERS+x} ] # We are on a CI worker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not much familiar with WORKERS
but CI
is the default env variable if it helps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this logic from the Java agent's push_docker.sh
Yes it is intended. Depending on the AWS Lambda architecture the users would use the corresponding image to get the extension with the correct arch. |
Closes #195