Skip to content

Conversation

estolfo
Copy link
Contributor

@estolfo estolfo commented Mar 2, 2022

Use the WaitGroup to block the extension for loop iteration from completing until the go routine sending to the apm server has returned.

Resolves #128

@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Mar 2, 2022
@ghost
Copy link

ghost commented Mar 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-02T10:42:18.827+0000

  • Duration: 6 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 84
Skipped 6
Total 90

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@jlvoiseux jlvoiseux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, it should solve #128

@estolfo estolfo merged commit eb3f041 into main Mar 2, 2022
@estolfo estolfo deleted the estolfo/waitgroup-error branch March 2, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic: sync: WaitGroup is reused before previous Wait has returned

2 participants