-
Notifications
You must be signed in to change notification settings - Fork 35
Refactor logsapi package #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
83315df
to
a5776fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems great to me ! Aside from reviewing the changes, I used E2E testing and ran this PR with my development Lambda functions and did not face any issue. The collection of platform metrics relies on the logsapi
package, but the only major change I see on my end is to move the definition of the platform report model from http_listener.go
to subscribe.go
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! left some comments / questions / suggestions
dbeef11
to
4cc9b37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
034b26c
to
6ec160d
Compare
This is a refactor of the logsapi package as per the review in #124
Changes include:
Subscribe
function that subscribes to the logsapi and starts an HTTP server listening for log eventsclient.go
but move the creation of the logsapi subscription structs in the client'sSubscribe
function and change the function signaturelogsapilistener.go
and move the functionality to theSubscribe
function insubscribe.go
subscribe_test.go
ELASTIC_APM_LAMBDA_LOGS_LISTENER_ADDRESS
Todo (3 March)