feat: add mariadb package instrumentation support #4045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
The wrapper lib I use call this with the .js so don't found the instrumentation
|
Hi @trentm and sorry for the direct ping! Can you review the changes or move my request to the right person? Thanks 😄 |
|
Any help? |
|
Deep sorry for the direct pings @trentm @colleenmcginnis @david-luna but if you can review this. I have a fork in production for almost a year working without problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the mariadb package, I copy the mysql2 implementation and make adjustments
Fixes #1759
Checklist