Skip to content

chore: bump min Node.js to v14.17; update deps #3611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 6, 2023
Merged

chore: bump min Node.js to v14.17; update deps #3611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6513f3f
chore: update deps
trentm Sep 5, 2023
6b567ab
back up to glob@8 to support node >=14.5, it supports >=12
trentm Sep 5, 2023
820c28d
back to pino@7 for node v14.5 support
trentm Sep 5, 2023
9d326b9
backup to rimraf 3, later versions require node v14.6 at least
trentm Sep 6, 2023
4ca4f80
bump our min-supported Node.js to 14.17
trentm Sep 6, 2023
e17bfe6
bump back to latest pino, glob, rimraf
trentm Sep 6, 2023
db550e8
make zero-conf tests resilient to unexpected log output from the APM …
trentm Sep 6, 2023
0ae805c
fix lint
trentm Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ jobs:
- '16'
- '16.0'
- '14'
- '14.0'
- '14.17'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ See the <<upgrade-to-v4>> guide.
[float]
===== Breaking changes

* Set the new minimum supported Node.js to version 14.5.0.
* Set the new minimum supported Node.js to version 14.17.0.
Users of earlier Node.js versions can use elastic-apm-node v3.x, which
supports back to Node.js v8.6.

Expand Down
2 changes: 1 addition & 1 deletion docs/supported-technologies.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Versions of Node.js past their end-of-life date are not supported.

image::./images/node_release_schedule.svg[Node.js release schedule]

APM agent 4.x releases work with Node.js versions 14.5.0 and later.
APM agent 4.x releases work with Node.js versions 14.17.0 and later.
APM agent 3.x maintenance releases work with Node.js versions 8.6 and later.
We will only break support for older Node.js versions with a major version release of the APM agent.

Expand Down
2 changes: 1 addition & 1 deletion docs/upgrade-to-v4.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ The following is a guide on upgrading your usage of the Elastic APM Node.js agen
[[v4-nodejs]]
==== Node.js versions

Version 4.x of `elastic-apm-node` supports Node.js v14.5.0 and later.
Version 4.x of `elastic-apm-node` supports Node.js v14.17.0 and later.
(The previous 3.x major supported back to Node.js v8.6.0.)


Expand Down
4 changes: 2 additions & 2 deletions lib/apm-client/http-apm-client/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ function Client(opts) {
// - `null`: the APM server version is unknown, could not be determined
// - a semver.SemVer instance
this._apmServerVersion = this._conf.apmServerVersion
? semver.SemVer(this._conf.apmServerVersion)
? new semver.SemVer(this._conf.apmServerVersion)
: undefined;
if (!this._apmServerVersion) {
this._fetchApmServerVersion();
Expand Down Expand Up @@ -1491,7 +1491,7 @@ Client.prototype._fetchApmServerVersion = function () {
? serverInfo.ok.version
: serverInfo.version;
try {
this._apmServerVersion = semver.SemVer(verStr);
this._apmServerVersion = new semver.SemVer(verStr);
} catch (verErr) {
setVerUnknownAndNotify(
`could not parse APM Server version "${verStr}": ${verErr.message}`,
Expand Down
Loading