Skip to content

chore: some small cleanups #3558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2023
Merged

chore: some small cleanups #3558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG4.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

==== Unreleased

See the <<upgrade-to-v4>> guide.

[float]
===== Breaking changes

Expand Down
3 changes: 0 additions & 3 deletions examples/trace-http-request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@

const apm = require('../').start({
serviceName: 'example-trace-http-request',
// Now that OpenTelemetry has been GA for a while, the Elastic-specific
// 'elastic-apm-traceparent' header is rarely needed.
useElasticTraceparentHeader: false,
});

const http = require('http');
Expand Down
1 change: 0 additions & 1 deletion examples/trace-http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

require('../').start({
serviceName: 'example-trace-http',
useElasticTraceparentHeader: false,
// 'usePathAsTransactionName' can be useful when not using a web framework
// with a router. See the following for details:
// https://www.elastic.co/guide/en/apm/agent/nodejs/current/custom-stack.html#custom-stack-route-naming
Expand Down
2 changes: 1 addition & 1 deletion test/types/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import assert from 'assert'

const agentOpts: AgentConfigOptions = {
captureExceptions: false,
metricsInterval: '0',
metricsInterval: '0s',
centralConfig: false
}
apm.start(agentOpts)
Expand Down