chore: move logging types #3546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
agent-nodejs
trentm
approved these changes
Aug 3, 2023
lib/logging.js
Outdated
Comment on lines
11
to
17
| * @property {function(Record<string, any> | string, ...any): undefined} log | ||
| * @property {function(Record<string, any> | string, ...any): undefined} info | ||
| * @property {function(Record<string, any> | string, ...any): undefined} warn | ||
| * @property {function(Record<string, any> | string, ...any): undefined} error | ||
| * @property {function(Record<string, any> | string, ...any): undefined} fatal | ||
| * @property {function(Record<string, any> | string, ...any): undefined} debug | ||
| * @property {function(Record<string, any> | string, ...any): undefined} trace |
There was a problem hiding this comment.
nit: There isn't a <logger>.log(...) function. (Technically there is a .silent(...) with Pino, but let's not mentioned that one here in our type.)
nit2: My OCD would be happier if these were listed in level order, e.g.: fatal, error, warn, info, debug, trace. :)
There was a problem hiding this comment.
let's make your OCD happy :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narrow a bit more the
Loggertypedef and move it tologging.jsfileChecklist