Skip to content

test: skip Azure Functions tests on Windows #3123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2023
Merged

test: skip Azure Functions tests on Windows #3123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@
"apollo-server-core": "^3.0.0",
"apollo-server-express": "^3.0.0",
"aws-sdk": "^2.622.0",
"azure-functions-core-tools": "^4.0.4915",
"backport": "^5.1.2",
"benchmark": "^2.1.4",
"bluebird": "^3.7.2",
Expand Down
31 changes: 27 additions & 4 deletions test/instrumentation/azure-functions/azure-functions.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
'use strict'

const assert = require('assert')
const { spawn } = require('child_process')
const { exec, spawn } = require('child_process')
const fs = require('fs')
const http = require('http')
const os = require('os')
const path = require('path')
Expand All @@ -22,6 +23,9 @@ const { formatForTComment } = require('../../_utils')
if (!semver.satisfies(process.version, '>=14 <19')) {
console.log(`# SKIP Azure Functions runtime ~4 does not support node ${process.version} (https://aka.ms/functions-node-versions)`)
process.exit()
} else if (os.platform() === 'win32') {
console.log('# SKIP Azure Functions tests on Windows because of flaky azure-functions-core-tools install (see https://github.com/elastic/apm-agent-nodejs/issues/3107)')
process.exit()
}

/**
Expand Down Expand Up @@ -179,6 +183,10 @@ function checkExpectedApmEvents (t, apmEvents) {

const UUID_RE = /^[0-9A-F]{8}-[0-9A-F]{4}-[0-9A-F]{4}-[0-9A-F]{4}-[0-9A-F]{12}$/i

const fnAppDir = path.join(__dirname, 'fixtures', 'AJsAzureFnApp')
const funcExe = path.resolve(fnAppDir, 'node_modules/.bin/func') + (
os.platform() === 'win32' ? '.cmd' : '')

var TEST_REQUESTS = [
{
testName: 'HttpFn1',
Expand Down Expand Up @@ -416,6 +424,24 @@ var TEST_REQUESTS = [
]
// TEST_REQUESTS = TEST_REQUESTS.filter(r => ~r.testName.indexOf('HttpFn1')) // Use this for dev work.

// We need to `npm ci` for a first test run.
tape.test(`setup: npm ci (in ${fnAppDir})`, { skip: fs.existsSync(funcExe) }, t => {
const startTime = Date.now()
exec(
'npm ci',
{
cwd: fnAppDir
},
function (err, stdout, stderr) {
t.error(err, `"npm ci" succeeded (took ${(Date.now() - startTime) / 1000}s)`)
if (err) {
t.comment(`$ npm ci\n-- stdout --\n${stdout}\n-- stderr --\n${stderr}\n--`)
}
t.end()
}
)
})

tape.test('azure functions', function (suite) {
let apmServer
let apmServerUrl
Expand All @@ -430,9 +456,6 @@ tape.test('azure functions', function (suite) {
})

let fnAppProc
const funcExe = path.resolve(__dirname, '../../../node_modules/.bin/func') + (
os.platform() === 'win32' ? '.cmd' : '')
const fnAppDir = path.join(__dirname, 'fixtures', 'AJsAzureFnApp')
suite.test('setup: "func start" for AJsAzureFnApp fixture', t => {
fnAppProc = spawn(
funcExe,
Expand Down
Loading