chore(deps-dev): bump ajv from 6.12.6 to 8.11.0 #2755
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=80&v=4){kind=small}
github-actions
bot
added
the
agent-nodejs
💔 Build Failed
Expand to view the summary
Build stats
Steps errors
Expand to view the steps failures
|
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.12.6 to 8.11.0. - [Release notes](https://github.com/ajv-validator/ajv/releases) - [Commits](ajv-validator/ajv@v6.12.6...v8.11.0) --- updated-dependencies: - dependency-name: ajv dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/ajv-8.11.0
branch
from
d3b8986 to
5410f2a
Compare
|
For now, I believe we should not switch to BTW the "ajv@8` because it technically drops support for node v8" is inferred from the https://github.com/ajv-validator/ajv/blob/master/README.md#features
which changed from:
for ajv@8 (commit e88b8f0fea6ab9f1aee966f1db2074755eb1196a). The GitHub Actions workflow also only tests with node 12, 14, and 16 as of the more recent commit commit 43d6164d46c1afbb1f40829f5208a66507af810c. That said, the tests using ajv do currently pass with [email protected] and [email protected]. patchIf/when we update to ajv@8 there are some changes necessary. The migration guide (https://github.com/ajv-validator/ajv/blob/master/docs/v6-to-v8-migration.md) alludes to the changes. Here is a patch to get the test passing with ajv@8: diff --git a/test/integration/api-schema/_utils.js b/test/integration/api-schema/_utils.js
index aa8a1c57..cd99db2d 100644
--- a/test/integration/api-schema/_utils.js
+++ b/test/integration/api-schema/_utils.js
@@ -6,7 +6,7 @@ const { join } = require('path')
const Ajv = require('ajv')
const thunky = require('thunky')
-const ajv = new Ajv({ allErrors: true })
+const ajv = new Ajv({ allErrors: true, allowUnionTypes: true, strict: true })
const schemaDir = join(__dirname, 'apm-server-schema')
exports.metadataValidator = thunky(function (cb) {
diff --git a/test/integration/api-schema/basic.test.js b/test/integration/api-schema/basic.test.js
index d415ea83..da1601c1 100644
--- a/test/integration/api-schema/basic.test.js
+++ b/test/integration/api-schema/basic.test.js
@@ -24,7 +24,7 @@ const next = afterAll(function (err, validators) {
test('metadata schema failure', function (t) {
t.strictEqual(validateMetadata({}), false)
validateFieldMessages(t, validateMetadata.errors, [
- { message: 'should have required property \'service\'' }
+ { message: 'must have required property \'service\'' }
])
t.end()
})
@@ -32,11 +32,11 @@ const next = afterAll(function (err, validators) {
test('transaction schema failure', function (t) {
t.strictEqual(validateTransaction({}), false)
validateFieldMessages(t, validateTransaction.errors, [
- { message: 'should have required property \'duration\'' },
- { message: 'should have required property \'id\'' },
- { message: 'should have required property \'span_count\'' },
- { message: 'should have required property \'trace_id\'' },
- { message: 'should have required property \'type\'' }
+ { message: 'must have required property \'duration\'' },
+ { message: 'must have required property \'id\'' },
+ { message: 'must have required property \'span_count\'' },
+ { message: 'must have required property \'trace_id\'' },
+ { message: 'must have required property \'type\'' }
])
t.end()
})
@@ -44,15 +44,15 @@ const next = afterAll(function (err, validators) {
test('span schema failure', function (t) {
t.strictEqual(validateSpan({}), false)
validateFieldMessages(t, validateSpan.errors, [
- { message: 'should have required property \'duration\'' },
- { message: 'should have required property \'id\'' },
- { message: 'should have required property \'name\'' },
- { message: 'should have required property \'parent_id\'' },
- { message: 'should have required property \'trace_id\'' },
- { message: 'should have required property \'type\'' },
- { message: 'should have required property \'start\'' },
- { message: 'should have required property \'timestamp\'' },
- { message: 'should match some schema in anyOf' }
+ { message: 'must have required property \'duration\'' },
+ { message: 'must have required property \'id\'' },
+ { message: 'must have required property \'name\'' },
+ { message: 'must have required property \'parent_id\'' },
+ { message: 'must have required property \'trace_id\'' },
+ { message: 'must have required property \'type\'' },
+ { message: 'must have required property \'start\'' },
+ { message: 'must have required property \'timestamp\'' },
+ { message: 'must match a schema in anyOf' }
])
t.end()
})
@@ -60,37 +60,37 @@ const next = afterAll(function (err, validators) {
test('error schema failure', function (t) {
t.strictEqual(validateError({}), false)
validateFieldMessages(t, validateError.errors, [
- { message: 'should have required property \'id\'' },
- { message: 'should have required property \'exception\'' },
- { message: 'should have required property \'log\'' },
- { message: 'should match some schema in anyOf' }
+ { message: 'must have required property \'id\'' },
+ { message: 'must have required property \'exception\'' },
+ { message: 'must have required property \'log\'' },
+ { message: 'must match a schema in anyOf' }
])
t.strictEqual(validateError({ id: 'foo', exception: {} }), false)
validateFieldMessages(t, validateError.errors, [
{
- dataPath: '.exception',
+ instancePath: '/exception',
params: { missingProperty: 'message' },
- message: 'should have required property \'message\''
+ message: 'must have required property \'message\''
},
{
- dataPath: '.exception',
+ instancePath: '/exception',
params: { missingProperty: 'type' },
- message: 'should have required property \'type\''
+ message: 'must have required property \'type\''
},
{
- dataPath: '.exception',
+ instancePath: '/exception',
params: {},
- message: 'should match some schema in anyOf'
+ message: 'must match a schema in anyOf'
}
])
t.strictEqual(validateError({ id: 'foo', log: {} }), false)
validateFieldMessages(t, validateError.errors, [
{
- dataPath: '.log',
+ instancePath: '/log',
params: { missingProperty: 'message' },
- message: 'should have required property \'message\''
+ message: 'must have required property \'message\''
}
])
t.end() |
|
@dependabot ignore this major version |
|
OK, I won't notify you about version 8.x.x again, unless you re-open this PR or update to a 8.x.x release yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps ajv from 6.12.6 to 8.11.0.
Release notes
Sourced from ajv's releases.
... (truncated)
Commits
c067d6d8.11.0a5119efUpdate limitProperties.ts (#1918)3ec588bFix some relative links (#1900)09f67f2fix: emit equal when needed - alternative to #1853 (#1922)bd7cf15Fix KeywordCxt links (#1931)95b15b6Use root schemaEnv when resolving references in oneOf (#1901)6e53e43doc: add uriResolver (#1896)a27f7828.10.0d0be809docs: fix typo in discriminator documentation (#1885)b3e0cb1docs: Fix typo (#1890)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)