3.30.0

[trentm]

Release version 3.30.0. It has been a month. This one has a couple significant changes:

• The capturing of span stacktraces is now disabled by default for perf reasons. The spanFramesMinDuration config var obsoletes captureSpanStackTraces and spanStackTraceMinDuration (the old ones still work). feat!, perf: spanStackTraceMinDuration config option, span.stacktrace disabled by default #2565 for details.
• Instrumentating Lambda functions:
  • One must use v0.0.4 of the Elastic APM Lambda extension or later, because new functionality in this version of the APM agent tickles a crash bug in older versions of the extension.
  • Instrumenting your Lambda functions is now easier: 1. add the Node.js APM agent layer to your lambda functions, 2. set the NODE_OPTIONS=-r elastic-apm-node/start environment variable, and then the manual apm.lambda(...) wrapping of your handler function is no longer necessary!

[astorm]

👍 /approved pending the usual "passes CI" shenanigans

[ghost]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-03-10T17:12:24.940+0000

• Duration: 28 min 9 sec

Test stats 🧪

Test	Results
Failed	0
Passed	242607
Skipped	0
Total	242607

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

• run benchmark tests : Run the benchmark test only.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[trentm]

v3.30.0 tag pushed
[email protected] published

[trentm]

https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/main/75/pipeline is the build to watch to see if the "Dist" and "Publish" steps work for the Lambda layers.

[trentm]

Or I am wrong. Build https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/main/75/pipeline/ did not run the Dist and Publish steps. I am not sure why.

The change that was meant to make this work was: #2585

Perhaps it is a timing issue?

• The PR for the release gets merged to main -> triggers Jenkins build of that commit
• A short time after (per the release steps), the tag is released and pushed.

So perhaps that triggered Jenkins build didn't see a tag yet. Timing in this case was:

• Jenkins build of main begins at 10-Mar-2022 6:26:57 PM (https://apm-ci.elastic.co/job/apm-agent-nodejs/job/apm-agent-nodejs-mbp/job/main/75/)
• The tag and push of the tag at "10:28:59" localtime, which is 18:28:59 UTC, which is 2m02s after the start of the above build.

[10:28:46 trentm@pink:~/pristine/apm-agent-nodejs (git:main)]
% git tag v3.30.0
[10:28:55 trentm@pink:~/pristine/apm-agent-nodejs (git:main)]
% git push origin !$
git push origin v3.30.0
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:elastic/apm-agent-nodejs.git
 * [new tag]           v3.30.0 -> v3.30.0
[10:28:59 trentm@pink:~/pristine/apm-agent-nodejs (git:main)]

I have started a new main build to see if that catches the tag: https://apm-ci.elastic.co/job/apm-agent-nodejs/job/apm-agent-nodejs-mbp/job/main/76/

If so, then we'll have to adjust the release process to ensure we get a "Dist/Release" of the release commit. If there is another commit to main immediately after the merge to main, then we might totally miss it.

[trentm]

Nope, build 76 (https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/main/76/pipeline) skipped the Dist and Publish steps as well. I don't know what is going on.

@v1v @astorm Are you able to help determine why we did not get a Jenkins build of the APM Agent Lambda Layer after the v3.30.0 tag that was added for this release? My understanding from #2585 is that this should have happened automatically after I pushed the tag. Or is there a separate step I need to take?

[trentm]

Lambda layer builds here: https://github.com/elastic/apm-agent-nodejs/releases/tag/v3.30.0
(after the build fix in #2609)