Skip to content

Conversation

Qard
Copy link
Contributor

@Qard Qard commented Apr 30, 2019

This makes kubernetes environment variables consistent with other agents while not breaking the prior behaviour. We should consider deprecating and removing the old environment variables in the next major.

Fixes #1028

Checklist

  • Implement code
  • Add tests
  • Update documentation

@Qard Qard force-pushed the fix-kubernetes-env-vars branch from b69404d to 8a0b713 Compare April 30, 2019 17:33
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs are 👍

@Qard
Copy link
Contributor Author

Qard commented May 1, 2019

@bmorelli25 What about docs redirects?

@bmorelli25
Copy link
Member

Good to go! None of the section IDs (e.g. [[kubernetes-node-name]]) need to change, so none of the urls will change.

@Qard
Copy link
Contributor Author

Qard commented May 1, 2019

Ah, right. Thanks. :)

@Qard Qard merged commit 403b27d into elastic:master May 1, 2019
@Qard Qard deleted the fix-kubernetes-env-vars branch May 1, 2019 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "ELASTIC_APM_" from k8s data environment variables

2 participants