Skip to content

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Apr 12, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested a review from killagu April 12, 2020 14:28
@codecov
Copy link

codecov bot commented Apr 12, 2020

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines           88       118   +30     
=========================================
+ Hits            88       118   +30     
Impacted Files Coverage Δ
app/extend/application.js 100.00% <100.00%> (ø)
app/extend/context.js 100.00% <100.00%> (ø)
config/config.default.js 100.00% <100.00%> (ø)
lib/cache_manager.js 100.00% <100.00%> (ø)
lib/http_proxy.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09dd217...178091b. Read the comment docs.

@atian25 atian25 force-pushed the cache branch 2 times, most recently from 0305056 to ced577a Compare April 14, 2020 14:59
@DuanPengfei
Copy link

LGTM;

@killagu
Copy link

killagu commented Apr 15, 2020

cache 处理遵守 http cache 规则会比较好,防止脏缓存出现。还可以加个 hook 由上层来决定缓存是否可使用。

@DuanPengfei
Copy link

@killagu http cache 规则是指遵循 etag 这种吗?

@killagu
Copy link

killagu commented Apr 19, 2020

是的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants