Skip to content

Conversation

matejc
Copy link

@matejc matejc commented Aug 2, 2021

Add Github Actions Tests workflow (using Nix to build the python/robotframework environment and run tests in it)
Tests being run in environments in combinations of python 3.8 and 3.9 across RF versions 3.1.2, 3.2, 3.2.1 and 3.2.2.

Passing tests: https://github.com/eficode/robotframework-oxygen/actions/runs/1090054551

@matejc matejc requested a review from Tattoo August 2, 2021 11:53
Copy link
Contributor

@Tattoo Tattoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Only few explaining comments to add and it's LGTM from me

steps:
- uses: actions/checkout@v2
- name: Install Nix
uses: cachix/install-nix-action@v13
with:
nix_path: nixpkgs=channel:nixos-unstable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate explaining short comment why are we using unstable instead of stable

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can even run without this option, since the default.nix and test.nix overrides it to release-21.05. Will try without it...

Copy link
Contributor

@Tattoo Tattoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome work

@Tattoo Tattoo merged commit 8571c85 into master Aug 23, 2021
@atombrella atombrella deleted the feat/cicd-tests/pr branch August 24, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants