Skip to content

Conversation

@jansenk
Copy link
Member

@jansenk jansenk commented Oct 21, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 21, 2025 02:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a GitHub Actions workflow to automate cherry-picking commits from the upstream openedx repository into the edX fork. The workflow is manually triggered and allows specifying a target commit hash to cherry-pick.

Key Changes:

  • Added a new workflow file that cherry-picks commits from openedx/frontend-app-learning into the fork
  • Implemented automated PR creation with commit metadata from the cherry-picked commit

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 22, 2025 14:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

EOF
)
gh pr create --title "${{ steps.commit-info.outputs.commit_subject }}" --body "$BODY" 1> pr_url 2> pr_errors
if [[ $? == 0 ]]; then
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ${PIPESTATUS[0]} instead of $? for consistency with the error handling pattern used in lines 43 and 50. This makes the error checking uniform throughout the workflow.

Copilot uses AI. Check for mistakes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jansenk , this seems like a correct suggestion. Can you either commit or resolve this with reason not to change?

@jansenk jansenk requested a review from nsprenkle October 22, 2025 14:01
@jansenk
Copy link
Member Author

jansenk commented Oct 22, 2025

I tested this on my personal fork. You can see some runs here:

https://github.com/jansenk/frontend-app-learning/actions/workflows/cherry-pick-openedx.yml

@jansenk
Copy link
Member Author

jansenk commented Oct 22, 2025

@jansenk
Copy link
Member Author

jansenk commented Oct 22, 2025

@nsprenkle nsprenkle changed the base branch from master to release-teak October 28, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants