-
Notifications
You must be signed in to change notification settings - Fork 3
feat: action for cherry-picking from openedx #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-teak
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a GitHub Actions workflow to automate cherry-picking commits from the upstream openedx repository into the edX fork. The workflow is manually triggered and allows specifying a target commit hash to cherry-pick.
Key Changes:
- Added a new workflow file that cherry-picks commits from openedx/frontend-app-learning into the fork
- Implemented automated PR creation with commit metadata from the cherry-picked commit
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| EOF | ||
| ) | ||
| gh pr create --title "${{ steps.commit-info.outputs.commit_subject }}" --body "$BODY" 1> pr_url 2> pr_errors | ||
| if [[ $? == 0 ]]; then |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use ${PIPESTATUS[0]} instead of $? for consistency with the error handling pattern used in lines 43 and 50. This makes the error checking uniform throughout the workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jansenk , this seems like a correct suggestion. Can you either commit or resolve this with reason not to change?
|
I tested this on my personal fork. You can see some runs here: https://github.com/jansenk/frontend-app-learning/actions/workflows/cherry-pick-openedx.yml |
|
Successful run, with link to PR: https://github.com/jansenk/frontend-app-learning/actions/runs/18717905668 |
No description provided.