fix #307: Progress View sometimes shows short living jobs twice #308
+30
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukzi
force-pushed
the
progressFlicker
branch
from
846e7c1 to
e124428
Compare
akurtakov
force-pushed
the
progressFlicker
branch
from
e124428 to
6dae0a0
Compare
…jobs twice There is a lot of code to handle equal JobTreeElement, but JobInfo did not implement equals(). Since the JobInfo is now reliable avoided to be added each time to the bottom, the sort order has to be maintained also on remove.
jukzi
force-pushed
the
progressFlicker
branch
from
6dae0a0 to
ede4ac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of code to handle equal JobTreeElement, but JobInfo did
not implement equals().
Since the JobInfo is now reliable avoided to be added each time to the
bottom, the sort order has to be maintained also on remove.