Skip to content

Add MouseEnter & MouseMove Event in PopupCloser #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

Add MouseEnter & MouseMove Event in PopupCloser #2977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fdedbf
Add MouseEnter & MouseMove Event in PopupCloser
amartya4256 May 13, 2025
70f04ae
Version bump(s) for 4.37 stream
fedejeanne Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/contentassist/PopupCloser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ public void install(ContentAssistant contentAssistant, Table table, AdditionalIn

fDisplay.addFilter(SWT.Deactivate, this);
fDisplay.addFilter(SWT.MouseUp, this);

fDisplay.addFilter(SWT.MouseMove, this);
fDisplay.addFilter(SWT.MouseEnter, this);
}
}

Expand All @@ -130,6 +133,9 @@ public void uninstall() {

fDisplay.removeFilter(SWT.Deactivate, this);
fDisplay.removeFilter(SWT.MouseUp, this);

fDisplay.removeFilter(SWT.MouseMove, this);
fDisplay.removeFilter(SWT.MouseEnter, this);
}
}

Expand Down Expand Up @@ -206,6 +212,8 @@ else if (event.type == SWT.MouseVerticalWheel)
}
break;

case SWT.MouseEnter:
case SWT.MouseMove:
case SWT.MouseUp:
if (fAdditionalInfoController == null || fAdditionalInfoController.getInternalAccessor().isReplaceInProgress())
break;
Expand All @@ -224,7 +232,7 @@ else if (event.type == SWT.MouseVerticalWheel)
}

// XXX: workaround for https://bugs.eclipse.org/bugs/show_bug.cgi?id=212392 :
control.getShell().getDisplay().asyncExec(() -> fAdditionalInfoController.getInternalAccessor().replaceInformationControl(true));
fAdditionalInfoController.getInternalAccessor().replaceInformationControl(event.type == SWT.MouseUp);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.ui.editors; singleton:=true
Bundle-Version: 3.20.0.qualifier
Bundle-Version: 3.20.100.qualifier
Bundle-Activator: org.eclipse.ui.internal.editors.text.EditorsPlugin
Bundle-ActivationPolicy: lazy
Bundle-Vendor: %providerName
Expand Down
2 changes: 1 addition & 1 deletion ...eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/TextEditorMessages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# IBM Corporation - initial API and implementation
###############################################################################

EditorsPlugin_additionalInfo_affordance=Press 'Tab' from proposal table or click for focus
EditorsPlugin_additionalInfo_affordance=Press 'Tab' from proposal table or click/hover for focus
EditorsPlugin_internal_error=Internal Error

TextEditorPreferencePage_displayedTabWidth=Displayed &tab width:
Expand Down
Loading