Skip to content

Conversation

@DaveCarpeneto
Copy link
Contributor

Fixes #2538

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 5b579e8d5906e4674b4f71fb4c8639bdd7a1964f Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 25 Nov 2024 14:58:40 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
index 5e9f968e31..52eee57bc2 100644
--- a/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.navigator.resources; singleton:=true
-Bundle-Version: 3.9.500.qualifier
+Bundle-Version: 3.9.600.qualifier
 Bundle-Activator: org.eclipse.ui.internal.navigator.resources.plugin.WorkbenchNavigatorPlugin
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

Test Results

 1 821 files  +  607   1 821 suites  +607   1h 50m 52s ⏱️ + 55m 0s
 7 725 tests ±    0   7 497 ✅ ±    0  228 💤 ±  0  0 ❌ ±0 
24 336 runs  +8 112  23 589 ✅ +7 832  747 💤 +280  0 ❌ ±0 

Results for commit 8f648e3. ± Comparison against base commit 7aaa014.

Copy link
Contributor

@jukzi jukzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message does not follow our best practice

@merks
Copy link
Contributor

merks commented Nov 26, 2024

The commit message does not follow our best practice

You mean it should summarize what is being changed and the perhaps include a more detailed description of the changes after the summary line.

I guess this is the "best practice" reference: (wrong-link-fixed)

https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

Though I wonder about recommending #<issue number> in the summary because the issue also listed in the body and the commit history does not suggest this is being done consistently.

@HannesWell Is the best practice description above still the up-to-date recommended best practice?

@jukzi
Copy link
Contributor

jukzi commented Nov 26, 2024

@DaveCarpeneto
Copy link
Contributor Author

Somehow I managed to open a new pull request instead of updating this pull request (apologies - I'm new to GitHub).

New pull request is #2542 . As such: closing this item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refresh option not available for some resources that are not closed projects

4 participants