-
Notifications
You must be signed in to change notification settings - Fork 226
Update ResourceMgmtActionProvider.java #2539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ResourceMgmtActionProvider.java #2539
Conversation
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
...rces/src/org/eclipse/ui/internal/navigator/resources/actions/ResourceMgmtActionProvider.java
Show resolved
Hide resolved
...rces/src/org/eclipse/ui/internal/navigator/resources/actions/ResourceMgmtActionProvider.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message does not follow our best practice
You mean it should summarize what is being changed and the perhaps include a more detailed description of the changes after the summary line. I guess this is the "best practice" reference: (wrong-link-fixed) Though I wonder about recommending @HannesWell Is the best practice description above still the up-to-date recommended best practice? |
|
This repository has a documentation in https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations |
|
Somehow I managed to open a new pull request instead of updating this pull request (apologies - I'm new to GitHub). New pull request is #2542 . As such: closing this item |
Fixes #2538