Skip to content

Replace AbstractHoverInformationControl on FocusIn #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Replace AbstractHoverInformationControl on FocusIn #2408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...eclipse.jface.text/src/org/eclipse/jface/text/AbstractHoverInformationControlManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ public void start(Rectangle subjectArea) {

fDisplay.addFilter(SWT.FocusOut, this);

fDisplay.addFilter(SWT.FocusIn, this);
fDisplay.addFilter(SWT.MouseDown, this);
fDisplay.addFilter(SWT.MouseUp, this);

Expand Down Expand Up @@ -270,6 +271,7 @@ else if (event.type == SWT.MouseVerticalWheel && cancelReplacingDelay())
}
break;

case SWT.FocusIn:
case SWT.MouseUp:
case SWT.MouseDown:
if (!hasInformationControlReplacer())
Expand All @@ -282,7 +284,7 @@ else if (!isReplaceInProgress()) {
if (!(iControl5.containsControl(control))) {
hideInformationControl();
} else if (cancelReplacingDelay()) {
if (event.type == SWT.MouseUp) {
if (event.type == SWT.MouseUp || event.type == SWT.FocusIn) {
stop(); // avoid that someone else replaces the info control before the async is exec'd
if (infoControl instanceof IDelayedInputChangeProvider) {
final IDelayedInputChangeProvider delayedICP= (IDelayedInputChangeProvider) infoControl;
Expand Down
Loading