Skip to content

Conversation

@DaveCarpeneto
Copy link
Contributor

Returns functionality whereby open projects and non-project resources get the 'refresh' contextual menu (option was removed for non-project resources via the fix @ eclipse-platform/eclipse.platform#876 ).

Returns functionality whereby open projects _and_ non-project resources get the 'refresh' contextual menu (option was removed for non-project resources via the fix @ eclipse-platform/eclipse.platform#876 ).
@github-actions
Copy link
Contributor

Test Results

 1 815 files  + 1   1 815 suites  +1   1h 35m 14s ⏱️ -42s
 7 663 tests ± 0   7 432 ✅  -  2  228 💤 ±0  3 ❌ +2 
24 150 runs  +98  23 398 ✅ +96  749 💤 ±0  3 ❌ +2 

For more details on these failures, see this check.

Results for commit eeb3bd7. ± Comparison against base commit 160dfa8.

@mickaelistria
Copy link
Contributor

What about making the condition if (projects.stream().anyMatch(IProject::isAccessible)) ?

@DaveCarpeneto
Copy link
Contributor Author

What about making the condition if (projects.stream().anyMatch(IProject::isAccessible)) ?

Given the boolean that "does the job" exists already, and this code runs on the main thread: what I put here should be quicker, especially if there's a lot of resources selected. However if you'd rather I went with something like the above please do let me know & I'll try again :-)

@mickaelistria
Copy link
Contributor

You're probably right. Let's merge it and revise it later if there are some issues.

@mickaelistria mickaelistria merged commit d6c128e into eclipse-platform:master Jun 26, 2024
@mickaelistria
Copy link
Contributor

Thank you

@DaveCarpeneto
Copy link
Contributor Author

Thank you

Thank you ;-)

Assuming this change stays in, will this be in 2024-09, or will it be in a subsequent release? Asking since I've got a variety of people over here crying about the missing functionality, and timelines seem to help when this happens ...

@merks
Copy link
Contributor

merks commented Jun 26, 2024

Yes, everything committed today will be in a nightly build with in a day:

https://download.eclipse.org/eclipse/updates/4.33-I-builds/

in a SimRel milestone build for M1 and in the final release:

https://download.eclipse.org/releases/milestone/
https://download.eclipse.org/releases/2024-09/

according to this schedule:

https://github.com/eclipse-simrel/.github/blob/main/wiki/SimRel/2024-09.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants