Skip to content

Refresh is disabled if closed projects are included #876 #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2023
Merged

Refresh is disabled if closed projects are included #876 #1438

merged 1 commit into from
Dec 20, 2023

Conversation

Dinesh0723
Copy link
Contributor

Refreshing all open projects, even if closed projects are included in the project explorer selection.

Fixes: eclipse-platform/eclipse.platform#876

@Dinesh0723
Refresh is disabled if closed projects are included eclipse-platform#876
687737c 


Refreshing all open projects, even if closed projects are included.

Fixes: eclipse-platform/eclipse.platform#876
@github-actions GitHub Actions
Copy link
Contributor

Test Results

     900 files  +       1       900 suites  +1   46m 14s ⏱️ + 7m 15s
  7 470 tests ±       0    7 317 ✔️ +       3  153 💤 ±    0  0 ❌  - 2 
23 559 runs  +1 577  23 048 ✔️ +1 459  511 💤 +121  0 ❌  - 2 

Results for commit 687737c. ± Comparison against base commit 44efc1d.

@vogella vogella merged commit 37040a7 into eclipse-platform:master Dec 20, 2023
@vogella
Copy link
Contributor

vogella commented Dec 20, 2023

Thanks @Dinesh0723, best UX improvement I have seen in a while.

sratz
sratz reviewed Dec 20, 2023
View reviewed changes
bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/WorkspaceAction.java
if (!super.updateSelection(selection) || selection.isEmpty()) {
return false;
}
if (getSelectedResources().size() > 1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange, what if all resources are inaccessible?

I propose the following:

		if (getSelectedResources().stream().allMatch(r -> !r.isAccessible())) {
			return false;
		}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sratz , If all resources are inaccessible, the 'right-click refresh' is not yet enabled.

@sratz
Copy link
Member

sratz commented Dec 20, 2023

Also, the javadoc
https://github.com/eclipse-platform/eclipse.platform.ui/pull/1438/files#diff-83c59417ce0b5f2301cc8e3e331aa6e690b3d38b1439db573a07bd0d2e06415fR361-R362
is now outdated.

@Dinesh0723 : Can you update this?

@DaveCarpeneto DaveCarpeneto mentioned this pull request Nov 25, 2024
Closed
2 tasks
DaveCarpeneto added a commit to DaveCarpeneto/eclipse.platform.ui that referenced this pull request Nov 26, 2024
@DaveCarpeneto
Refresh option not available for some resources that are not closed p…
062aa39 
…rojects eclipse-platform#2538

Change made since the fix to eclipse-platform#1438 unintentionally removed the "refresh" contextual menu for resources that are not projects. 

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes eclipse-platform#2538
@DaveCarpeneto DaveCarpeneto mentioned this pull request Nov 26, 2024
Closed
DaveCarpeneto added a commit to DaveCarpeneto/eclipse.platform.ui that referenced this pull request Dec 3, 2024
@DaveCarpeneto
Update NavigatorTestSuite.java
ea04dc7 
Refresh option not available for some resources that are not closed projects eclipse-platform#2538

Change made since the fix to eclipse-platform#1438 unintentionally removed the "refresh" contextual menu for resources that are not projects. 

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes eclipse-platform#2538
DaveCarpeneto added a commit to DaveCarpeneto/eclipse.platform.ui that referenced this pull request Dec 3, 2024
@DaveCarpeneto
Create ResourceMgmtActionProviderTests.java
8bdef7e 
Refresh option not available for some resources that are not closed projects eclipse-platform#2538

Change made since the fix to eclipse-platform#1438 unintentionally removed the "refresh" contextual menu for resources that are not projects. 

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes eclipse-platform#2538
DaveCarpeneto added a commit to DaveCarpeneto/eclipse.platform.ui that referenced this pull request Dec 4, 2024
@DaveCarpeneto
Refresh option not available for some resources that are not closed p…
76d98bb 
…rojects

Refresh option not available for some resources that are not closed projects eclipse-platform#2538

Change made since the fix to eclipse-platform#1438 unintentionally removed the "refresh" contextual menu for resources that are not projects.

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes eclipse-platform#2538
DaveCarpeneto added a commit to DaveCarpeneto/eclipse.platform.ui that referenced this pull request Dec 9, 2024
@DaveCarpeneto
Refresh option not available for some resources that are not closed p…
996f5bf 
…rojects eclipse-platform#2538

Change made since the fix to eclipse-platform#1438 unintentionally removed the "refresh" contextual menu for resources that are not projects.

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes eclipse-platform#2538
@DaveCarpeneto DaveCarpeneto mentioned this pull request Dec 9, 2024
Merged
jukzi pushed a commit to DaveCarpeneto/eclipse.platform.ui that referenced this pull request Dec 10, 2024
@DaveCarpeneto @jukzi
Refresh option not available for some resources that are not closed p…
39da4c6 
…rojects eclipse-platform#2538

Change made since the fix to eclipse-platform#1438 unintentionally removed the "refresh" contextual menu for resources that are not projects.

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes eclipse-platform#2538
DaveCarpeneto added a commit to DaveCarpeneto/eclipse.platform.ui that referenced this pull request Dec 17, 2024
@DaveCarpeneto
Refresh option not available for some resources that are not closed p…
2bd50e4 
…rojects eclipse-platform#2538

Update javadoc for ResourceMgmtActionProviderTests.java

Change made since the fix to eclipse-platform#1438 unintentionally removed the "refresh" contextual menu for resources that are not projects.

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes eclipse-platform#2538
DaveCarpeneto added a commit to DaveCarpeneto/eclipse.platform.ui that referenced this pull request Dec 17, 2024
@DaveCarpeneto
Refresh option not available for some resources that are not closed p…
cc8ef59 
…rojects eclipse-platform#2538

Change made since the fix to eclipse-platform#1438 unintentionally removed the "refresh" contextual menu for resources that are not projects.

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes eclipse-platform#2538
DaveCarpeneto added a commit to DaveCarpeneto/eclipse.platform.ui that referenced this pull request Dec 17, 2024
@DaveCarpeneto
Refresh option not available for some resources that are not closed p…
e9e5521 
…rojects eclipse-platform#2538

Change made since the fix to eclipse-platform#1438 unintentionally removed the "refresh" contextual menu for resources that are not projects.

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes eclipse-platform#2538
jukzi pushed a commit to DaveCarpeneto/eclipse.platform.ui that referenced this pull request Dec 18, 2024
@DaveCarpeneto @jukzi
Refresh option not available for some resources that are not closed p…
88557dd 
…rojects eclipse-platform#2538

Change made since the fix to eclipse-platform#1438 unintentionally removed the "refresh" contextual menu for resources that are not projects.

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes eclipse-platform#2538
merks pushed a commit that referenced this pull request Dec 18, 2024
@DaveCarpeneto @merks
Refresh option not available for some resources that are not closed p…
b019337 
…rojects #2538

Change made since the fix to #1438 unintentionally removed the "refresh" contextual menu for resources that are not projects.

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes #2538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sratz sratz sratz left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refresh in project explorer disabled if closed projects are included in the selection

3 participants

@Dinesh0723 @vogella @sratz