Image.getHandle(): return ImageHandle instead of long #2651
Conversation
ShahzaibIbrahim
force-pushed
the
master-442-new-return-handle
branch
from
245c1de to
f47774d
Compare
There was a problem hiding this comment.
@ShahzaibIbrahim #2615 contains a bunch of replacements of calls to win32_getHandle() with calls o getHandle(), which are also only refactorings and should be done in a separate PR than that one (so can potentially be included in this one).
ShahzaibIbrahim
force-pushed
the
master-442-new-return-handle
branch
2 times, most recently
from
cc9165f to
9e42b1d
Compare
every image handle holds more than just the handle value and can be required by the caller to determine the characteristics of an Image.
HeikoKlare
force-pushed
the
master-442-new-return-handle
branch
from
9e42b1d to
ed37bf8
Compare
There was a problem hiding this comment.
The change seems fine. I have only updated it with an encapsulation of ImageHandle#handle to avoid that it gets overridden accidentally from anywhere outside the Image class.
@ShahzaibIbrahim As a follow up in #2615, we can get rid of the Image parameters in some GC methods, as they were only passed for the transparentPixel/transparentColor fields, which are then properly part of the ImageHandle.
As another follow-up cleanup, I will take care of removing the now rather obsolete HandleAtSizeConsumer.
2 participants
Every image handle holds more than just the handle value and can be required by the caller to determine the characteristics of an Image.