[Win32] Fix initial control location #2643 #2644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a recent change to the initial location of newly created controls, the locations of some controls inside shells are broken. The intent of that previous change was to improve the initial location of shells. This change adapts the previous modification to only apply an improved pattern for initial shell placement when the control is actually shell and to keep the previous behavior for all other controls. Fixes eclipse-platform#2643
HeikoKlare
force-pushed
the
issue-2643
branch
from
a239da0 to
6355e39
Compare
Contributor
akoch-yatta
approved these changes
Oct 17, 2025
Contributor
akoch-yatta
left a comment
akoch-yatta
left a comment
There was a problem hiding this comment.
As this change was targeted on fixing the positioning on Shell anyway it makes sense to limit the affected places to Shell and move the custom code to there
fedejeanne
approved these changes
Oct 17, 2025
Member
fedejeanne
left a comment
fedejeanne
left a comment
There was a problem hiding this comment.
Makes sense to localize the fix for shells and leave out other controls.
Thank you, Heiko!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a recent change to the initial location of newly created controls, the locations of some controls inside shells are broken. The intent of that previous change was to improve the initial location of shells.
This change adapts the previous modification to only apply an improved pattern for initial shell placement when the control is actually shell and to keep the previous behavior for all other controls.
Fixes #2643