[Win32] Fix wrong layout when opening shell or reparenting control #2608 #2637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 16, 2025
Contributor
…lipse-platform#2608 In multiple situation, relayouting due to DPI change events does not work as expected: - When opening child shells, they may be relayouted after being opened if their position changed to a different monitor between the OS handle was created and a new position was set - When reparenting controls between different shells, the target shell may not be properly relayout at all Since the user experience when performing these two cases asynchronously is not good anyway (e.g., reparenting leads to unexpected asynchronous relayouting operations), this change adapts the two use cases to process the DPI change synchronously. Fixes eclipse-platform#2608
HeikoKlare
force-pushed
the
issue-2608
branch
from
642e207 to
fcfd25f
Compare
akoch-yatta
approved these changes
Oct 16, 2025
Contributor
akoch-yatta
left a comment
akoch-yatta
left a comment
There was a problem hiding this comment.
Changes sound reasonable for the scenarios it describes. I tested it with different monitor setting and scenarios like opening child shells, triggering parent changes or moving shells between monitors and it works as expected and I didn't find a regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multiple situation, relayouting due to DPI change events does not work as expected:
Since the user experience when performing these two cases asynchronously is not good anyway (e.g., reparenting leads to unexpected asynchronous relayouting operations), this change adapts the two use cases to process the DPI change synchronously.
Fixes #2608
This is an addition to #2636, which already fixes some of the issue (in the best possible way) while this resolved the remaining issues (such as broken perspective switching) on top.
You can test this by having two monitors with different zoom, starting an SDK product and switching perspectives on either of the monitors. Without this fix, you will see the broken layout as described here: #2608 (comment)
In addition, you can open a child shell (e.g., an "Open Type" dialog) and move it to a different monitor, such that it reopens on that other monitor afterwards. Without this fix, when reopening the dialog you will see effects such as in #2608 (comment).