Replace File Extension based on user selection #2620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsazac
changed the title
elsazac
force-pushed
the
fileExtension
branch
from
acf2c98 to
33e198c
Compare
|
@vogella Could you check this? |
vogella
approved these changes
Oct 13, 2025
|
LGTM from looking at the code |
|
@orionll please confirm that this patch solves your problem |
|
@vogella, with this change the dialog returns a correct extension. |
elsazac
force-pushed
the
fileExtension
branch
from
33e198c to
51d47bd
Compare
vogella
approved these changes
Oct 16, 2025
elsazac
force-pushed
the
fileExtension
branch
from
51d47bd to
7f931cb
Compare
|
Build failing due to eclipse-tycho/tycho#5473 |
Nope... see comment. Either Infrastructure is unstable or some changes in PDE/ApiTools related in Platform... One might want to run a local maven build and attach a debugger to see what actually is missing here. |
elsazac
force-pushed
the
fileExtension
branch
3 times, most recently
from
02bc0ad to
af249f1
Compare
|
Build looks good; Merging this now |
elsazac
force-pushed
the
fileExtension
branch
from
af249f1 to
94b6c4b
Compare
Currently if there is no file extension for the file, then only the new extension is getting appended; but there is no implementation if there is an extension already present for the file and the user wants to overwrite it; The PR is raised to include that condition too.
elsazac
force-pushed
the
fileExtension
branch
from
94b6c4b to
d4c041e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #2566
Fix file extension in macOS
Previously, the FileDialog would only append the selected file extension if there is no extension attached to the filename. However, if the filename already had an extension, it has to removed to accommodate the user input extension.
This PR updates the implementation to replace the existing extension with the user input file extension.