Skip to content

Conversation

jonahgraham
Copy link
Contributor

The pre-existing implementation of Clipboard for GTK4 only allowed copying and pasting within the application.

Fixes #2126

@jonahgraham jonahgraham added the gtk4 GTK4 issues label Oct 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Test Results

   88 files   - 27     88 suites   - 27   8m 3s ⏱️ - 3m 49s
4 558 tests  -  4  4 540 ✅  -  6  18 💤 +2  0 ❌ ±0 
  261 runs   - 50    258 ✅  - 50   3 💤 ±0  0 ❌ ±0 

Results for commit 3ac5dc8. ± Comparison against base commit 9e3ae28.

This pull request removes 6 and adds 2 tests. Note that renamed tests count towards both.
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_Clipboard ‑ test_LocalClipboard(int)[2]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_Clipboard ‑ test_Remote(int)[2]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_Clipboard ‑ test_getContents(int)[2]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_Clipboard ‑ test_getContentsAsync(int)[2]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_Clipboard ‑ test_setContents(int)[2]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_GC ‑ test_drawImageLorg_eclipse_swt_graphics_ImageIIII_ImageDataAtSizeProvider(int)
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_Clipboard ‑ test_getAvailableTypeNames(int)[1]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_Clipboard ‑ test_getAvailableTypes(int)[1]
This pull request skips 3 tests.
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_Clipboard ‑ test_getContentsBothClipboards
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_Clipboard ‑ test_setContentsBothClipboards
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Shell ‑ test_activateEventSend

♻️ This comment has been updated with latest results.

@jonahgraham jonahgraham self-assigned this Oct 6, 2025
@jonahgraham jonahgraham force-pushed the clipboard branch 5 times, most recently from aac1268 to 28f4799 Compare October 22, 2025 00:50
@jonahgraham
Copy link
Contributor Author

jonahgraham commented Oct 22, 2025

In addition the automated tests contained within this change the other ways to test this change involves manually running:

  • multiple instances of ClipboardExample (in SWT examples), in both GTK3 and GTK4 and ensuring that all types can be copied between instances. Using gtk4-demo is also useful.
  • the snippets for the Clipboard
  • the manual test for the Clipboard Bug567826_CrashClipboardExit

Testing has been done in GNOME (mutter wayland compositor), KDE (Kwin wayland compositor) and Xfce, both with clipboard managers disabled and enabled, with both Wayland and X11 as backend (X11 running in Xtigervnc for Xfce cases and Xwayland for wayland cases). Testing all completed on Ubuntu 25.10.

@jonahgraham jonahgraham marked this pull request as ready for review October 22, 2025 16:32
@jonahgraham
Copy link
Contributor Author

Ready for review (but there are a bunch of parent PRs to merge first, so really only review the last commit in this PR).

…cations

The pre-existing implementation of Clipboard for GTK4 only allowed
copying and pasting within the application.

Fixes eclipse-platform#2126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gtk4 GTK4 issues

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[GTK4] Implement Full Clipboard support for GTK4

1 participant