Avoid failing test because temporary directory cannot be deleted #2575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows the temporary directory sometimes cannot be deleted because the files are still locked and you get an error like: The process cannot access the file because it is being used by another process This change allows the deletion of the temp directory to fail without failing the whole test. In case the temp dir can't be deleted a warning is printed on System.err Fixes #2568
|
@jonahgraham maybe something to report to junit team so |
|
Already discussions in JUnit about it - see link in the issue #2568 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows the temporary directory sometimes cannot be deleted because the files are still locked and you get an error like:
The process cannot access the file because it is being used by another process
This change allows the deletion of the temp directory to fail without failing the whole test. In case the temp dir can't be deleted a warning is printed on System.err
Fixes #2568