Skip to content

Conversation

@tmssngr
Copy link
Contributor

@tmssngr tmssngr commented Oct 1, 2025

The indentation was screwed up, so it was hard to understand the logic.

I also removed the unused assignment to result and the empty else-branch.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Test Results

  111 files   -  7    111 suites   - 7   11m 29s ⏱️ +22s
4 528 tests  - 55  4 513 ✅  - 34  14 💤  - 22  0 ❌ ±0  1 🔥 +1 
  274 runs   - 56    273 ✅  - 34   1 💤  - 22  0 ❌ ±0 

For more details on these errors, see this check.

Results for commit d383295. ± Comparison against base commit 48e5878.

This pull request removes 56 and adds 1 tests. Note that renamed tests count towards both.
AllWin32Tests ImageWin32Tests ‑ testDisposeDrawnImageBeforeRequestingTargetForOtherZoom
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromCopiedImage
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromImageForImageDataFromImage
AllWin32Tests TestTreeColumn ‑ test_ColumnOrder
…
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_dnd_Clipboard ‑ Unknown test

@jonahgraham
Copy link
Contributor

@tmssngr the failed test on Windows is something new I introduced and the Windows failure is being investigated in #2568

Thomas Singer added 2 commits October 31, 2025 10:30
- remove empty `else` branch
- remove unused `result`
@tmssngr tmssngr force-pushed the format-Control.gtk_motion_notify_event branch from d383295 to d8dfeb3 Compare October 31, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants