-
Notifications
You must be signed in to change notification settings - Fork 185
Add diagnostics to failing Clipboard test and skip on non-GTK #2555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnostics to failing Clipboard test and skip on non-GTK #2555
Conversation
ad4e4cc to
7c3476a
Compare
bf08e16 to
a339199
Compare
Test Results 111 files ±0 111 suites ±0 10m 54s ⏱️ - 1m 39s For more details on these failures, see this check. Results for commit bdf184b. ± Comparison against base commit 87fa834. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
|
@jonahgraham : the four failing tests are known, see #2516 Do you plan to cotinue working on this PR or can it be merged "as is"? |
This records additional information about the state of the remote process. This will only hard fail on Linux as we have seen test pass on Linux, and Linux is the primary target as the Clipboard is under development on Linux only now for GTK4 work. Part of #2553
a339199 to
bdf184b
Compare
|
Just rebased on latest master with the workaround for Windows GHA test fails. |
It can be merged now, the build hadn't finished before my day ended on Friday. So I will merge now.
Thanks There is a new unrelated failure: test_setUrl_remote_with_post[browser flags: 524,288] (org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser) failed I assume this is flaky and I can ignore it for now (I don't have time/ability to fix it and I am pretty sure it is unrelated to my change). Let me know if you would like me to do anything else with it. |
See #2561 |
|
https://download.eclipse.org/eclipse/downloads/drops4/I20250930-1800/testResults.php shows no failures - but see #2126 (comment) which I quote here for those following along:
|
This records additional information about the state of the remote process. This will only hard fail on Linux as we have seen test pass on Linux, and Linux is the primary target as the Clipboard is under development on Linux only now for GTK4 work.
Part of #2553