Skip to content

Fix Javadoc of SVGRasterizer #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2025
Merged

Fix Javadoc of SVGRasterizer #2536

merged 1 commit into from
Sep 23, 2025

Conversation

@arunjose696
Copy link
Contributor

@arunjose696 arunjose696 commented Sep 23, 2025

This commits fixes Javadoc of SVGRasterizer and adds tests to verify the contract

Fixes #2515

@arunjose696 arunjose696 mentioned this pull request Sep 23, 2025
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025 •
edited
Loading

Test Results

  118 files  ±0    118 suites  ±0   10m 33s ⏱️ + 1m 21s
4 435 tests +3  4 413 ✅ +2  17 💤 ±0  5 ❌ +1 
  298 runs  ±0    289 ✅  - 1   4 💤 ±0  5 ❌ +1 

For more details on these failures, see this check.

Results for commit 27b2438. ± Comparison against base commit 7d4190a.

♻️ This comment has been updated with latest results.

HeikoKlare
HeikoKlare reviewed Sep 23, 2025
View reviewed changes
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adapting the contract. I have some comments. Can you please also add a reference to the resolved issue in the commit message?

@HeikoKlare HeikoKlare linked an issue Sep 23, 2025 that may be closed by this pull request
Javadoc of SVGRasterizer is wrong vi-eclipse/Eclipse-Platform#452
Closed
@arunjose696 arunjose696 force-pushed the arunjose696/2515/javadoc branch 3 times, most recently from b5614aa to fa53b86 Compare September 23, 2025 13:44
@arunjose696
Copy link
Contributor Author

arunjose696 commented Sep 23, 2025

Can you please also add a reference to the resolved issue in the commit message?

Done

HeikoKlare
HeikoKlare reviewed Sep 23, 2025
View reviewed changes
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw that the new test classes is not added to any test suite yet, which is why it is not executed in any CI runs. It should be added to AllNonBrowserTests.
@arunjose696 can you please do that? Then this should be ready to go from my side.

@arunjose696 arunjose696 force-pushed the arunjose696/2515/javadoc branch 2 times, most recently from 5b11d60 to 5b29c56 Compare September 23, 2025 14:29
@arunjose696
Copy link
Contributor Author

arunjose696 commented Sep 23, 2025

It should be added to AllNonBrowserTests. @arunjose696 can you please do that? Then this should be ready to go from my side.
Done

@arunjose696 arunjose696 force-pushed the arunjose696/2515/javadoc branch from 5b29c56 to 2872a87 Compare September 23, 2025 14:55
@arunjose696 @HeikoKlare
Fix Javadoc of SVGRasterizer
27b2438 
This commits fixes Javadoc of SVGRasterizer and adds tests to verify the
contract

Fixes eclipse-platform#2515
@HeikoKlare HeikoKlare force-pushed the arunjose696/2515/javadoc branch from 2872a87 to 27b2438 Compare September 23, 2025 15:02
@HeikoKlare HeikoKlare merged commit 5d2665d into eclipse-platform:master Sep 23, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HeikoKlare HeikoKlare HeikoKlare approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Javadoc of SVGRasterizer is wrong Javadoc of SVGRasterizer is incomplete or wrong

2 participants

@arunjose696 @HeikoKlare