[Win32] Fix wrong line height in StyledText #2405 #2406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line height in StyledText is currently too large when the auto-scaled device zoom is larger than the native zoom. This for example happens on a 175% primary monitor with `swt.autoScale=int200` or with a fixed `swt.autoScale` value that is higher than the primary monitor zoom. This was caused by a recent change that accidentally used the auto-scaled zoom instead of the native zoom for retrieving a font handle combined with the general usage of the ScalingSWTFontRegistry that, in comparison to the previous fixed-zoom registry, now returns an accordingly scaled handle. This change adapts the font handle retrieval to properly pass the native zoom instead of the auto-scaled zoom. Fixes eclipse-platform#2405
Contributor
akoch-yatta
approved these changes
Aug 11, 2025
Contributor
akoch-yatta
left a comment
akoch-yatta
left a comment
There was a problem hiding this comment.
Code change made sense as well as why the original change didn't have an effect until recently. I tested with all autoscale mode on 175 and on 150 zoom and didn't find a regression. Good to go from my side
This was referenced Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line height in StyledText is currently too large when the auto-scaled device zoom is larger than the native zoom. This for example happens on a 175% primary monitor with
swt.autoScale=int200or with a fixedswt.autoScalevalue that is higher than the primary monitor zoom. This was caused by a recent change that accidentally used the auto-scaled zoom instead of the native zoom for retrieving a font handle combined with the general usage of the ScalingSWTFontRegistry that, in comparison to the previous fixed-zoom registry, now returns an accordingly scaled handle.This change adapts the font handle retrieval to properly pass the native zoom instead of the auto-scaled zoom.
Fixes #2405
Screenshots
Left is before the change, right is after:
